proxy: preserve upstream authenticated data - #519
Open
Sil3ntVip3r wants to merge 1 commit into
Open
Conversation
This was referenced Aug 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updates AdguardTeam/AdGuardHome#3017.
DNS proxy correctly clears the AD bit before replying to a client that did not request authenticated data or DNSSEC records. That client-specific filtering also made the original upstream validation result unavailable to downstream consumers such as the AdGuard Home query log.
This change adds DNSContext.ResponseAD, capturing the response AD bit before client filtering for both fresh upstream and cached responses. The value is reset for every Resolve call and copied through pending-request coalescing, so generated failures, reused contexts, leaders, and waiters cannot receive stale or inconsistent metadata. The wire response behavior remains unchanged.
Red-first coverage includes:
Validation:
The commit used --no-verify only because this environment cannot complete the hook live public-resolver integration tests; those same tests repeatedly timed out or reset on the sibling dnsproxy work. The affected package and all non-live project checks above completed successfully.
After this dependency change is merged and released, AdGuard Home can switch its query-log metadata assignment from the filtered response field to ResponseAD in a small follow-up.